[Feat] Add DRAM pool KV protocol with unified pack/unpack - #1040
Open
yumingyue624 wants to merge 1 commit into
Open
[Feat] Add DRAM pool KV protocol with unified pack/unpack#1040yumingyue624 wants to merge 1 commit into
yumingyue624 wants to merge 1 commit into
Conversation
yumingyue624
requested review from
Infinite666,
Wwwzff,
mag1c-h and
nrj868
as code owners
June 22, 2026 08:43
yuanzhg078
reviewed
Jun 22, 2026
yumingyue624
force-pushed
the
dram_pool_kv_protocol
branch
from
June 22, 2026 09:51
6ba00a7 to
ee357e1
Compare
Infinite666
reviewed
Jun 22, 2026
yumingyue624
force-pushed
the
dram_pool_kv_protocol
branch
from
June 24, 2026 02:03
7bec951 to
ee357e1
Compare
yuanzhg078
reviewed
Jun 24, 2026
yumingyue624
force-pushed
the
dram_pool_kv_protocol
branch
from
June 24, 2026 06:43
6d5aee6 to
2febc62
Compare
## Purpose Implement pack/unpack for the DRAM pool KV transport (send + flag buffer), mirroring the ASU architecture. ## Modifications 1. kv_protocol.h: shared types, constants, helpers (PeekOpcode, IsAllZeroKey, ProtocolName, PackHeader, ValidateRequestHeader), and a unified KvProtocol base class with 5 virtual methods covering both client side (PackedSize, PackRequest, UnpackResponse) and server side (UnpackRequest, PackResponse). KvDumpLoadProtocol and KvLookupProtocol implement all five; ProtocolManager dispatches by opcode. 2. kv_protocol.cpp: implementations for all protocols and the manager. 3. Tests: 29 cases covering pack/unpack round-trips, boundary values, multi-entry, opcode validation, and edge cases. ## Test - dramstore.test: 29 gtests passing.
yumingyue624
force-pushed
the
dram_pool_kv_protocol
branch
from
June 24, 2026 06:53
2febc62 to
f27b8a9
Compare
yumingyue624
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implement pack/unpack for the DRAM pool KV transport (send + flag buffer), mirroring the ASU architecture.
Modifications
Test