add log for pd nixl#1324
Open
hiworldwzj wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces GPU timing measurements for memory page copy operations and logs the elapsed time. It also adds latency tracking for adding remote agents in the NIXL KV transporter. The feedback suggests defensively checking that both copy_start_event and copy_end_event are not None before calculating the elapsed time to prevent potential AttributeError exceptions.
Comment on lines
+362
to
+364
| if copy_end_event is not None: | ||
| copy_end_event.synchronize() | ||
| read_page_gpu_time_ms = copy_start_event.elapsed_time(copy_end_event) |
Contributor
There was a problem hiding this comment.
To ensure robust defensive programming, verify that both copy_end_event and copy_start_event are not None before calling elapsed_time to prevent potential AttributeError exceptions.
Suggested change
| if copy_end_event is not None: | |
| copy_end_event.synchronize() | |
| read_page_gpu_time_ms = copy_start_event.elapsed_time(copy_end_event) | |
| if copy_end_event is not None and copy_start_event is not None: | |
| copy_end_event.synchronize() | |
| read_page_gpu_time_ms = copy_start_event.elapsed_time(copy_end_event) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.