refactor: generalize hybrid attention checkpoint management - #1559
Open
shihaobai wants to merge 2 commits into
Open
refactor: generalize hybrid attention checkpoint management#1559shihaobai wants to merge 2 commits into
shihaobai wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the existing linear/full checkpoint flow into reusable hybrid interfaces, without including the Gemma/sliding-window implementation.
HybridAttentionReqManagerfor request-state initialization, big/small-page snapshots, restoration and model-specific MTP state updates. Conv/SSM access stays inside the linear implementation.common/state_cache_manager/: shared slot allocator and layer storage, with the linear config and buffers together inlinear_att.py.--linear_att_*options. PD I/O structures,page_kindliterals and model-specific PD packing/restoration remain identical to main.No changes to attention computation, Gemma/sliding runtime allocation or the small-page policy in this PR.
Validation
Revalidated the review cleanup at
5f1c96a3on 2026-09-10 with the same cases and main baseline.Executed in
bsh_dsv4with Qwen3.5-27B, BF16, TP=1 on H200 GPUs, against pristine main1eb4810c.test_radix_cache.py::test_case10fails on pristine main as well because its tree has no mem_manager; reproduced separately and excluded from the final selected run.pre-commit(Black and Flake8) passed inside the container.The validation launcher starts P before D to avoid main's existing concurrent NCCL control-port selection race. No unrelated startup fix is included.