fix(audio_io): remove unreachable duplicate except in torchcodec probe - #1487
Open
Anai-Guo wants to merge 1 commit into
Open
fix(audio_io): remove unreachable duplicate except in torchcodec probe#1487Anai-Guo wants to merge 1 commit into
Anai-Guo wants to merge 1 commit into
Conversation
The torchcodec import probe had two identical `except Exception` handlers. The first (silent) one shadows the second, so the handler that logs the import error was dead code. Drop the redundant silent handler so the intended error message is emitted on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
lightx2v/utils/audio_io.py, thetorchcodecimport probe declares two identicalexcept Exceptionhandlers:Two handlers for the same exception type in one
tryare evaluated top-down, so the first (silent) handler always wins and the second — the one that actually logs why the probe failed — is unreachable dead code.Fix
Drop the redundant silent handler and keep the informative one, so an import failure is reported instead of swallowed:
One-hunk change; behavior on success is unchanged, and a failing probe now surfaces the underlying error.
🤖 Generated with Claude Code