Split between Type and Codec#46
Merged
Merged
Conversation
…taResult for keeping track of serialization errors and to allow partial recovery; made Type.write use it.
…ethod references.
…ad of building a new map.
…ift-based to apply-based
Contributor
Author
|
That's expected since |
boq
requested changes
May 12, 2020
slicedlime
previously approved these changes
May 12, 2020
Member
slicedlime
left a comment
slicedlime
left a comment
There was a problem hiding this comment.
Nitpicks about code ordering.
Also really missing tests for this like we discussed, but leaving that for later.
boq
previously approved these changes
May 12, 2020
grum
reviewed
May 12, 2020
grum
reviewed
May 12, 2020
grum
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptionalwithDataResultto better track errors and allow recovery