Merge upstream changes#2
Open
whitebelyash wants to merge 26 commits into
Open
Conversation
SPIRV-Tools v2026.2.rc1 Glslang latest SPIRV-Headers latest
Google-internal bug 393437270
Google internal bug 506281797
re2: 2025-11-08.bcr.1 matching abseil_cpp latest SPIRV-Tools, Glslang, SPIRV-Headers Abseil should link the MSVC runtime statically, unless building shared libs
Bug: crbug.com/3046665
Those files are generated during the ndk-build test
The HLSL front end in Glslang is deprecated and will eventually be removed. KhronosGroup/glslang#4210 Add CMake configuration option SHADERC_ENABLE_HLSL, defaulting to ON. In the future the default will switch to OFF. Adjust unit tests and glslc end-to-end tests. Issue: google#1556
Refactor so it shares common scripts with the ndk-build flow. bonk this
Update the README and CHANGES See KhronosGroup/glslang#4210
Also in kokoro scripts: - ndk-build expects 0 or non-zero for SHADERC_ENABLE_HLSL - fix executable perm on ndk-build-nohlsl/build.sh
Previously, preprocessor definition ENABLE_HLSL was always created. Now, define it only when CMake build option SHADERC_ENABLE_HLSL is on.
`gcc-17` cleaned up transitive header inclusion and exposed missing
header as a build failure:
```
In file included from /build/source/libshaderc_util/src/io_shaderc.cc:15:
/build/source/libshaderc_util/include/libshaderc_util/io_shaderc.h:54:31: error: 'std::ofstream' has not been declared
54 | std::ofstream* file_stream, std::ostream* err);
| ^~~
```
Add a null check for the return value of GetOutputStream() in dependency_info.cc before dereferencing the stream pointer. When GetOutputStream() fails to open the output file (e.g., due to permission errors, full disk, or non-existent directory), it returns nullptr. The code previously unconditionally dereferenced this pointer, causing a segmentation fault (SIGSEGV). This is the same vulnerability pattern that was fixed in file_compiler.cc (commit 1d97901), but was missed in the dependency_info.cc code path. The fix follows the identical pattern: check the pointer for null before use and return false on failure. Bug: Null pointer dereference when glslc is invoked with -MD flag and the dependency info output file cannot be opened for writing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.