Skip to content

modifying test about connection#1670

Open
Davidrjx wants to merge 11 commits intoMongoEngine:masterfrom
Davidrjx:rjxdev
Open

modifying test about connection#1670
Davidrjx wants to merge 11 commits intoMongoEngine:masterfrom
Davidrjx:rjxdev

Conversation

@Davidrjx
Copy link
Copy Markdown
Contributor

@Davidrjx Davidrjx commented Oct 4, 2017

new test package called connections and move related modules in;
new related test methods;

@Davidrjx Davidrjx changed the title Rjxdev modifying test about connection Oct 5, 2017
Ren Jianxin added 4 commits October 7, 2017 21:22
involving replica set connection config tuning and related tests
delete print statement
tuning test methods under py2
follow flake8
@Davidrjx
Copy link
Copy Markdown
Contributor Author

Davidrjx commented Nov 7, 2017

do someone as an assignee make the review for this request?

@wojcikstefan
Copy link
Copy Markdown
Member

wojcikstefan commented Nov 7, 2017

Hi @Davidrjx ! Could you summarize these changes in the PR's description? Just a few brief sentences what it gives us, why it's useful, whether it's backward compatible, what was the problem with the previous structure, etc.

Ping me please when that's done and I'll review.

@wojcikstefan wojcikstefan self-requested a review November 7, 2017 14:41
@Davidrjx
Copy link
Copy Markdown
Contributor Author

Davidrjx commented Nov 8, 2017

@wojcikstefan thanks for your reply. The pull request mainly contains:
(1) for replicaset and readpreference option in mongodb, do some adjustments in mongoengine connection module to make connection setting more suitable for Pymongo client.
previous possible problems: a bit unclear/incorrect connection setting arguments processing in kwargs/uri_opt.
(2) at the same time, combined with modifications above, also i do the same thing for connection test, which involves test module location tuning and methods new addition.
previous possible problems: uncomfortable module archive and incomplete tests.
(3) above tests are run with Py2(2.7),Py3(3.4) and Pymongo2(2.9&2.8),Pymongo3(3.3)

@Davidrjx
Copy link
Copy Markdown
Contributor Author

@wojcikstefan please review

@wojcikstefan wojcikstefan removed their request for review August 30, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants