Dereferencing abstract documents correctly from reference fields and from_son#1801
Open
mmoonport wants to merge 5 commits intoMongoEngine:masterfrom
Open
Dereferencing abstract documents correctly from reference fields and from_son#1801mmoonport wants to merge 5 commits intoMongoEngine:masterfrom
mmoonport wants to merge 5 commits intoMongoEngine:masterfrom
Conversation
Author
|
Any idea on when this might get merged in. I would love to get off of my fork. |
Collaborator
|
Hi @mmoonport, first of all thanks for the contribution. If possible, I think adding some test could help to have this merged |
Collaborator
|
@mmoonport Kind reminder about this PR, I'm still looking forward to see a test (that was failing before and that would now pass) for validating this change. The description from the Issue ticket isn't explicit enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #1332. We run a very abstract relationship structure and ran into this issue many times. It turns out dereference wasn't honoring the cls attribute set on DBRefs when we make abstract documents. Also added the same checks into LazyReferenceField.
Hope this helps