Open
Conversation
Monte9
requested changes
Apr 2, 2024
Owner
Monte9
left a comment
Monte9
left a comment
There was a problem hiding this comment.
Thanks for the PR. Suggested a few changes before we can merge this!
Author
|
@Monte9 Hey man, sorry for the late notice. I made the changes as per your request, now I just need you to resolve the conflict. It seems like a small one for the props of the TapRating component. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using the
TapRatingcomponent in a work project and want to do testing for the component with Jest. I've added a testID input and default value, as well as some testIDs for parts of the component.Pretty simple PR, but let me know if there are any guidelines I should have followed or any name changes you would like to be made.
Cheers!