fix(verify): discover authorized Docker tests before blocking - #11
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08704b7958
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| In MoonMind, inspect the exposed container tool contract and CLI help, and use | ||
| the repository's managed test entrypoint or | ||
| `moonmind container run --spec <job.json> --request-id <stable-phase-id>` | ||
| with a job specification derived from documented test commands and approved | ||
| image sources. The API-owned Docker Backend supplies the daemon and toolchain; |
There was a problem hiding this comment.
When this bundle is projected into consumers other than MoonMind, it now carries a MoonMind-only CLI command and API-owned backend contract, coupling the canonical verifier to one consumer and requiring bundle changes whenever that consumer API evolves. Keep the portable verifier limited to discovering an authorized container entrypoint, and place the concrete moonmind container run contract in MoonMind's AGENTS.md or consumer documentation.
AGENTS.md reference: AGENTS.md:L21-L23
Useful? React with 👍 / 👎.
1 participant
Description
Require the portable verifier to discover repository-documented Docker test paths and attempt authorized container checks before declaring a local toolchain blocker. Retain terminal evidence or concrete admission diagnostics, and reuse a stable request ID when retrying identical generic jobs.
This is the canonical bundle update consumed by MoonLadderStudios/MoonMind#4203. Repository-specific test commands and images remain in consumer guidance; managed execution preserves existing authorization boundaries.
Testing
Bundle validation passed:
python3 tools/validate_bundle.py.All 17 tests passed in an isolated Python environment:
python -m pytest.MoonMind skill/loader and container CLI coverage: 70 tests passed. A managed-session reliability replay is being added in the consumer PR.
Tested locally with
uv run specify --helpRan existing tests with
uv sync && uv run pytestTested with a sample project (if applicable)
AI Disclosure
Codex authored and validated the instruction change and prepared this PR.