Open
Conversation
nightgryphon
commented
May 18, 2020
- python playlist handler fix
- shoutcast metadata update fix to use with recent libshout3
- timestamps in logs
fix shoutcast metadata update with libshout-2.4.1 caused by ssl/tls autodetection
AlphaJack
reviewed
Sep 7, 2020
| static void ices_log_string(char *format, char *string) { | ||
| time_t t = time(NULL); | ||
| char tstr[48]; | ||
| strftime(tstr, sizeof(tstr), "%Y.%m.%d %H:%M:%S", localtime(&t)); |
There was a problem hiding this comment.
Is it possible to use hyphens in timestamps and use a different timestamp separator (no 4th colon)? The final result could be like this:
2020-09-07 20:21:22 - Playing /path/to/track1
2020-09-07 20:23:22 - Playing /path/to/track2
At the moment it's more like this:
2020.09.07 20:21:22: Playing /path/to/track1
2020.09.07 20:23:22: Playing /path/to/track2
Author
|
Of course. That's just text logging. You can use any format you like.
…On Mon, Sep 7, 2020, 21:34 AlphaJack ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/log.c
<#4 (comment)>:
> @@ -140,16 +141,23 @@ char *ices_log_get_error(void) {
/* Function to log string to both console and file */
static void ices_log_string(char *format, char *string) {
+ time_t t = time(NULL);
+ char tstr[48];
+ strftime(tstr, sizeof(tstr), "%Y.%m.%d %H:%M:%S", localtime(&t));
Is it possible to use hyphens in timestamps and use a different timestamp
separator (no 4th colon)? The final result could be like this:
2020-09-07 20:21:22 - Playing /path/to/track1
2020-09-07 20:23:22 - Playing /path/to/track2
At the moment it's more like this:
2020.09.07 20:21:22: Playing /path/to/track1
2020.09.07 20:23:22: Playing /path/to/track2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4RAJ47BQDQZZ4JINLAFMDSEURSFANCNFSM4NEPRRXA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.