Moved subtitle selector into it's own file and unit test#324
Open
TheyCallMeSpy wants to merge 3 commits into
Open
Moved subtitle selector into it's own file and unit test#324TheyCallMeSpy wants to merge 3 commits into
TheyCallMeSpy wants to merge 3 commits into
Conversation
Contributor
|
one small cleanup request: Also, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Extracts subtitle track selection logic from item_detail_screen.dart into a standalone subtitle_track_logic.dart utility, making it pure and unit-testable. Adds fixture-based unit tests and a fixture loader helper.
Type of Change
Changes Made
List the key changes included in this PR.
Platform
Testing
Describe how this change was tested.
Test Steps
Checklist