autosave when applying settings to users#149
Open
jmawet wants to merge 1 commit into
Open
Conversation
Build SuccessfulThe plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the config saving part out of the "submit" eventlistener into its own function.
The submit eventlistener now calls this new function, so save button function is unaffected.
The pushdefaults buttons now also call submit() before doing anything else, ensuring the config is saved before pushing it to users.
This avoids admins having to save first before pushing to users. They may be confused trying to push settings that they're not getting applied, so this removes that extra step and reduces confusion.
I compiled/installed on my server and tested, it works. I can now change any default settings and push to my user, they apply immediately on other devices, and the "settings saved" popup can be seen confirming it as well.