fix: load MCP tools only for main agent #541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoju111a
changed the title
xiaoju111a
force-pushed
the
fix/mcp-duplicate-init
branch
from
351974b to
1e9454c
Compare
Move MCP loading from load_agent() to KimiCLI.create() to ensure MCP servers are initialized only once, regardless of subagent count. Closes MoonshotAI#518
xiaoju111a
force-pushed
the
fix/mcp-duplicate-init
branch
from
1e9454c to
14b410a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix duplicate MCP server initialization when loading agents with subagents.
Closes #518
Problem
When kimi-cli starts, it loads main agent + subagents. Both received the same
mcp_configs, causing:Solution
Move MCP loading logic from
load_agent()toKimiCLI.create():load_agent()no longer handles MCP configsThis aligns with Claude Code's approach: MCP is a shared resource, configured once globally.
Files Changed
src/kimi_cli/soul/agent.py- Removemcp_configsparametersrc/kimi_cli/app.py- Add MCP loading after agent creationtests/andexamples/- Updateload_agent()calls