Skip to content

Conversation

@xxchan
Copy link
Collaborator

@xxchan xxchan commented Jan 4, 2026

Summary

  • ship built-in skill-creator in the package skills directory
  • load builtin skills alongside user skills with user overrides
  • update docs, NOTICE, packaging, and tests

Testing

  • uv run pytest tests/test_skill.py

Copilot AI review requested due to automatic review settings January 4, 2026 14:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds built-in skill support to Kimi CLI by shipping a "skill-creator" skill inside the application bundle and implementing a system to load both built-in and user skills with user override capability.

Key Changes

  • Implemented multi-root skill discovery with user override support (later directories override earlier ones)
  • Added built-in "skill-creator" skill with comprehensive guidance for creating effective skills
  • Updated PyInstaller configuration to bundle the skills directory with the application

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/kimi_cli/skill.py Added get_builtin_skills_dir() and discover_skills_from_roots() functions to support discovering skills from multiple directories with override behavior
src/kimi_cli/soul/agent.py Updated agent initialization to discover skills from both builtin and user directories, with user skills overriding builtin ones
src/kimi_cli/skills/skill-creator/SKILL.md Added comprehensive 373-line built-in skill providing guidance for creating and managing skills
src/kimi_cli/utils/pyinstaller.py Added skills/** pattern to include builtin skills in the PyInstaller bundle
tests/test_skill.py Added test for discover_skills_from_roots() function verifying the override behavior
docs/en/customization/skills.md Updated English documentation to explain built-in skills and override behavior
docs/zh/customization/skills.md Updated Chinese documentation to explain built-in skills and override behavior
NOTICE Added attribution for OpenAI Codex content used in the skill-creator skill

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e85d7eb8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Collaborator

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on adding built-in skills support!

What I like:

  1. Proper attribution in NOTICE file for Codex-derived content
  2. User skills can override built-in skills - good design
  3. discover_skills_from_roots() cleanly handles multiple skill directories
  4. Documentation updated in both EN and ZH

The skill-creator content itself:

  • Comprehensive guide for creating skills
  • Good principles: conciseness, degrees of freedom, practical examples
  • Covers both user-invocable and proactive skills

Questions/Suggestions:

  1. The skill content is quite long (300+ lines). Is there a way to load it lazily only when needed?
  2. Will there be more built-in skills in the future? If so, might be worth documenting the criteria for what becomes built-in vs. user-provided

Overall a solid addition that will help users create better skills!

Reviewed by Alice (AI agent)

stdrc and others added 4 commits January 6, 2026 19:31
- Replace 23 occurrences of "Codex" with "Kimi" in skill-creator SKILL.md
- Update CHANGELOG.md with Unreleased entry for built-in skill-creator
- Sync English and Chinese changelog docs
- Keep built-in skills documentation in skills.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc merged commit e41163a into main Jan 6, 2026
7 checks passed
@stdrc stdrc deleted the feat/builtin-skills branch January 6, 2026 12:24
@xxchan
Copy link
Collaborator Author

xxchan commented Jan 6, 2026

Thanks for the thoughtful review!

On lazy loading: discovery only parses the YAML frontmatter (via read_frontmatter), and the full SKILL.md is read only when a skill is invoked (e.g. /skill:...). So the long content should not add much startup overhead; happy to optimize further if we see a perf issue.

On future built-ins: no concrete plan right now beyond keeping the built-in set minimal and broadly useful. If we add more, I can document clearer criteria (e.g. cross-project utility + low maintenance + good user override story).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants