fix(tui): dismiss /btw panel before cancelling compaction on Esc and Ctrl+C#1811
Merged
Conversation
🦋 Changeset detectedLatest commit: 190edc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below.
Problem
While a compaction is running, opening a /btw side question and pressing Esc (or Ctrl+C) cancels the in-progress compaction instead of dismissing the /btw panel. The editor keyboard handler checked the compacting state before the open /btw panel, so the panel stayed mounted and the compaction was aborted — the user had to press Esc again to actually close the panel.
What changed
Reordered the Esc and Ctrl+C handling so an open /btw panel is handled first: Esc dismisses the panel, and Ctrl+C cancels a running /btw question (then closes the panel) — all without touching the compaction. Compaction is only cancelled once no /btw panel is open, which matches the "dismiss the topmost UI layer first" expectation. This fits Kimi Code because it only reorders existing handler branches in the TUI keyboard controller; no SDK or core behavior changes. Added controller tests covering both keys with the panel open, gone, and absent.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.