fix(scripts): materialize explicit E2E prompts (#38) + self-contained wrapper distribution check (#39)#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proofrun, while preserving the step-by-step public ORRO smoke flow.setuptoolsexplicitly absent, then using pip build isolation behind--allow-networkto provisionsetuptools>=61.Root causes
#38
scripts/orro_e2e_smoke.pypassed the role-lane plan emitted byflowplandirectly toproofrun. Its executable lane still used the generatedExecute ORRO role ...placeholder, which latest witnessd correctly rejects fail-closed.The smoke now replaces prompts only for
may_execute=truelanes with its declared task, preserves non-executable prompts, and recordsflowplan_materializes_explicit_role_lane_promptsbefore callingproofrun.#39
scripts/check_orro_wrapper_distribution.pyinvokedpip wheel --no-build-isolation, so success depended on the invoking interpreter already importingsetuptools.build_meta.The checker now creates a separate build venv, removes and probes for
setuptools, requires explicit--allow-network, and lets PEP 517 build isolation provision the declared backend. Current docs and CI use the explicit flag; offline--self-testremains network-free.RED evidence
#38 against witnessd 68e468d + Depone 46c55bd
#39 from a fresh venv without setuptools
Verification
68e468d61d16c2eef63cadbe28e757fdd8dcf483and Depone46c55bd4e137f6760ada848c84ebaee6c72b7ac7.flowplan_materializes_explicit_role_lane_promptspassed with one executable lane materialized beforeproofrun.setuptools_absent=True, exit 0,build_venv_has_no_setuptools_before_buildpassed.contains_depone=false,contains_witnessd=false,contains_engine_logic=false.git diff --checkpassed.The witnessd placeholder guard was not weakened or modified. Neither witnessd nor Depone was changed.