feat(wrapper): unify orro-product-wrapper into the publishable orro package (in-process witnessd delegation)#52
Closed
moonweave wants to merge 4 commits into
Closed
feat(wrapper): unify orro-product-wrapper into the publishable orro package (in-process witnessd delegation)#52moonweave wants to merge 4 commits into
orro package (in-process witnessd delegation)#52moonweave wants to merge 4 commits into
Conversation
…witnessd delegation) Reconcile the two divergent orro wrappers into one: rename the distribution orro-product-wrapper -> orro (version 0.1.0, supersedes the standalone 0.0.3), declare the witnessd>=2.3.2 engine dependency, and replace the subprocess 'python -m orro' delegation with in-process delegation that imports witnessd's ORRO_COMMANDS + main. A real ORRO command routes to witnessd_main(["orro", ...]); an unknown command gets an ORRO-owned diagnostic (named token + closest match + valid list, exit 2); boundary/self-test remain local honesty commands. Python stays under src/orro_wrapper per the repo contract; publishing is a separate step. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing — scope discovery. Making the ORRO repo the source of the published
So the reconciliation is a deliberate strategy change (ORRO flips from 'unpublished thin skeleton' to 'published product package'), touching docs + contract, not just packaging. Re-doing cleanly with subprocess delegation kept and the invariant docs/contract updated, pending a go/no-go on that direction. |
orro package (in-process witnessd delegation)
Contributor
Author
|
Superseded by #53 (merged), which unified the wrapper with subprocess delegation kept and all CI checks + pinned-engine-smoke passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciliation
This makes the ORRO repo the single canonical, version-controlled source of the published-name
orropackage. It reconciles the repo's formerorro-product-wrapperskeleton with the working standaloneorro0.0.3 design:orro-product-wrappertoorro;0.1.0, superseding published0.0.3;witnessd>=2.3.2;python -m orrodelegation replaced with in-processwitnessd.__main__delegation;orro_wrapperremains the import package and owns bothorroand theorro-wrappercompatibility entry point;No witnessd or Depone source was changed. The wrapper still contains no engine logic and retains the existing proof/verifier/approval/assurance boundary fields.
Dispatch order
boundary,self-test, anddelegatestay wrapper-local.witnessd.__main__.ORRO_COMMANDSroutes towitnessd_main(["orro", *args]).unknown commanddiagnostic, closest-match suggestion when available, the union of witnessd and local commands, and exit 2.RED and verification
RED was observed before implementation:
flowplan --helpreached the deprecated subprocess shim and the patched in-processwitnessd_mainmock was called zero times.Fresh verification on
/usr/bin/python3:python3 scripts/check_orro_wrapper.py— passpython3 scripts/check_orro_repo_contract.py— passpython3 scripts/check_orro_command_migration_dry_run.py --json— passpython3 scripts/check_orro_wrapper_install.py --json— passpython3 scripts/check_orro_wrapper_distribution.py --json --allow-network— passpython3 -m build— builtorro-0.1.0.tar.gzandorro-0.1.0-py3-none-any.whlpython3 -m pytest -q— no tests collected, exit 0; repository tests are the configured checker suite abovegit diff --check— passThe full pinned-engine E2E could not run in this fresh local clone because sibling
../witnessdand../Deponecheckouts are absent. Its wrapper regression was updated to install the declared dependency; GitHub's E2E workflow supplies those pinned checkouts and is the authoritative rerun.Live smoke