chore: Merge upstream changes - #2
Merged
Merged
Conversation
add(index, item) went through slideRight(), which reserved exactly the missing slot, so every insertion reallocated and copied the whole array. Building a type block entry by entry, as merging tables does, was quadratic because of it. Also fix ensureCapacity(int) allocating too little when some capacity is already free: it subtracted the free slots from the request and then added the result to the size instead of to the current length, which could leave fewer free slots than asked for.
Grow ArrayCollection geometrically when inserting at an index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.