Enable Planechase and Archenemy variants in the network lobby - #25
Closed
MostCromulent wants to merge 1 commit into
Closed
Enable Planechase and Archenemy variants in the network lobby#25MostCromulent wants to merge 1 commit into
MostCromulent wants to merge 1 commit into
Conversation
The desktop lobby's network variant list has excluded Planechase, Archenemy, and Archenemy Rumble since Feb 2018, when every variant was blanket-disabled during a multiplayer lobby rework and then re-enabled one at a time. These three were never re-verified before that work stopped, and the commented-out entry has been carried along unchanged by every later variant addition. Nothing else in the codebase gates them for network play. The view layer already tracks the PlanarDeck and SchemeDeck zones, the planar player, and the current plane; DeltaSyncManager derives its zone set from ZoneType so it needs no update; and the Planes and Schemes deck sections already travel over UpdateLobbyPlayerEvent. All variant logic runs in forge-game on the host. The mobile lobby has never had this restriction, so mobile hosts can already start these matches online. The per-player planar and scheme deck controls key off synced lobby data rather than this list, so an older client joining a host that enables these variants still gets its deck selectors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Card-Forge#11811 — Card-Forge#11811
Planechase, Archenemy, and Archenemy Rumble are missing from the online lobby. They've been commented out of
vntBoxesNetworksince Feb 2018, when2b704e16c7blanket-disabled every variant during a multiplayer lobby rework. The others were re-enabled over the following days; these three never were. This PR uncomments them — one line.Code analysis found no fundamental blocker:
VLobby.java:95is the only place in the codebase gating these for network play.PlanarDeck/SchemeDeckzones,PlanarPlayer, andCurrentPlaneare tracked properties;DeltaSyncManagerderives its zone set fromZoneTypeso needs no update; thePlanes/Schemesdeck sections travel over the sameUpdateLobbyPlayerEventpath Vanguard'sAvatarsection uses today.forge-game.OnlineLobbyScreen extends LobbyScreen, which registers all ten variants.Deliberately an unblocking change rather than a fix for hypothetical problems — enabling them is what will surface real bugs in normal play, where they can be reported and fixed on their merits. The issue reporter built and played with these enabled without apparent issues.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rh3k6Tb5fws2AtuabjeQeL
Generated by Claude Code