Repository navigation
Normalize relative paths in nebel add - #9
Merged
Merged
Conversation
nebel add field ./test.yaml and nebel add file ./*.yaml wrote the raw, un-normalized path/glob into .gitattributes and .nebel.yaml. git never reports a leading "./" for tracked files, so the pattern silently failed to match and the file was left unencrypted. Fixes #8 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nebel add field ./test.yaml ...andnebel add file ./*.yamlwrote the raw, un-normalized path/glob straight into.gitattributesand.nebel.yaml../for tracked files, so the pattern silently failed to match and the file was left unencrypted.normalizePathhelper (filepath.Clean+filepath.ToSlash) applied to the CLI argument in bothrunAddFieldandrunAddFile, before it's used for the file read, the config rule, and the.gitattributesline.Fixes #8
Note for anyone with an already-affected repo
Existing
.nebel.yaml/.gitattributesentries with a literal./prefix (written before this fix) are dead weight after upgrading — they can be deleted by hand; re-runningnebel addwill add the correctly normalized rule alongside them.Test plan
go build ./...go test ./...(full suite passes)TestAddFieldNormalizesRelativePath,TestAddFileNormalizesRelativePathincmd/nebel/addfield_e2e_test.go