Add the PaymentData object to an OrderRequest#19
Add the PaymentData object to an OrderRequest#19firstred wants to merge 4 commits intoMultiSafepay:masterfrom
PaymentData object to an OrderRequest#19Conversation
|
Hi @firstred , Thank you for your contribution. We are currently looking into it and will provide an update later. |
|
Hi @firstred , The changes look good, we are going to include them in the next release. This is a welcome change that makes it easier to add the The OrderRequest object extends from the RequestBody object. The RequestBody object extends from the DataObject object. In the DataObject there is a method called addData(); We will come back to you when the release has been done with your suggested improvements. |
|
Thanks for your reply and looking into it! I wasn't aware that it was possible to add additional data, I expected that it would be filtered out. Great as a workaround for now, thanks! I'll have a look at the code style and make the necessary changes. |
|
Hi @firstred , We've merged this internally and added you as a contributer: https://github.com/MultiSafepay/php-sdk/releases/tag/5.19.0 I'm closing this one for now. Thanks again! |
This PR adds the missing
PaymentDataobject.Not sure if the
tokenizeproperty should be added, but it is described on the payment components page (step 3): https://archive.is/wjc5DIt is missing from the API reference, though (Body Params: Payment Component): https://docs.multisafepay.com/reference/createorder