Converting to a standalone adapter - #2
Draft
kayaercument wants to merge 2 commits into
Draft
Conversation
mnfarooqi
reviewed
Jul 21, 2026
| FetchContent_Declare( | ||
| mqss-client | ||
| GIT_REPOSITORY https://github.com/kayaercument/MQSS-Client.git | ||
| GIT_TAG develop |
Collaborator
There was a problem hiding this comment.
A version tag would be more stable as the develop is going to change over time.
| # Define the JIT lowering pipeline | ||
| jit-mid-level-pipeline: "lower-to-cfg,quake-to-cc-prep,func.func(expand-control-veqs,combine-quantum-alloc,canonicalize,combine-measurements)" | ||
| # Tell the rest-qpu that we are generating OpenQASM 2.0. | ||
| codegen-emission: qasm2 |
Collaborator
There was a problem hiding this comment.
Any option for the user to set it to a different IR type? e.g. quake or qir?
| @@ -0,0 +1,39 @@ | |||
| set(LIBRARY_NAME mqss-adapter) | |||
Collaborator
There was a problem hiding this comment.
Would it be a good idea to move this CMake file to the root folder?
| /// @brief the platform file path | ||
| std::filesystem::path platformPath; | ||
|
|
||
| mqss::client::MQSSClient client; |
Collaborator
There was a problem hiding this comment.
Does it need to be public?
| const cudaq::AnyModule &module, | ||
| cudaq::KernelArgs args) { | ||
| throw std::runtime_error( | ||
| "MQSSQPU does not support launching the async_sample_policy."); |
Collaborator
There was a problem hiding this comment.
Why MQSS can't support async? What is needed to support async?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to convert the existing implementation into a standalone implementation.
How to run it:
A couple of things need to be improved:
FYI: @ctminh @echavarria-mqv