🎨 Minor Improvements

CMakeLists.txt

@@ -34,6 +34,7 @@ option(BUILD_UNIT_TESTS "Build the unit tests" OFF)
 option(BUILD_INTEGRATION_TESTS "Build the unit tests" OFF)
 option(ENABLE_COVERAGE "Enabling coverage" OFF)
 option(BUILD_BINDINGS "Build Python Bindings" OFF)
+option(BUILD_SHARED_LIBS "Build Shared Library " ON)
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
 

src/CMakeLists.txt

@@ -21,7 +21,12 @@ find_package(rabbitmq-c REQUIRED)
 
 file(GLOB_RECURSE MQSS_CLIENT_SOURCES **.cpp)
 
-add_library(mqss_client SHARED ${MQSS_CLIENT_SOURCES})
+if(BUILD_SHARED_LIBS)
+  add_library(mqss_client SHARED ${MQSS_CLIENT_SOURCES})
+else()
+  add_library(mqss_client STATIC ${MQSS_CLIENT_SOURCES})
+  set_target_properties(mqss_client PROPERTIES POSITION_INDEPENDENT_CODE ON)
+endif()
 
 target_include_directories(
   mqss_client PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include>

src/c_bindings/job.cpp

@@ -22,6 +22,8 @@
 #include "common.h"
 #include "mqss/job.h"
 
+#include <sstream>
+
 using namespace mqss::client;
 
 MQSSJobRef MQSSClientCreateCircuitJob(char* circuit, char* circuitFormat,

src/client.cpp

@@ -95,7 +95,12 @@ std::string MQSSClient::getJobStatus(const JobRequest& job) {
     return "";
 
   nlohmann::json parsed = nlohmann::json::parse(resp);
-  return parsed.value("status", "");
+
+  if (parsed.contains("status") && parsed["status"].is_string()) {
+    return parsed["status"].get<std::string>();
+  }
+
+  return "";
 }
 
 std::unique_ptr<JobResult> MQSSClient::getJobResult(const JobRequest& job,

src/clients/rest_client.cpp

@@ -62,6 +62,7 @@ std::string MQSSRestClient::get(const std::string& path) {
   curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void*)&response);
   curl_easy_setopt(curl, CURLOPT_URL, (mUrl + path).c_str());
   curl_easy_setopt(curl, CURLOPT_HTTPHEADER, pHeaders);
+  curl_easy_setopt(curl, CURLOPT_CAINFO, std::getenv("CURL_CA_BUNDLE"));
 
   CURLcode res = curl_easy_perform(curl);
   if (res != CURLE_OK)
@@ -91,6 +92,7 @@ std::string MQSSRestClient::post(const std::string& path,
   curl_easy_setopt(curl, CURLOPT_POSTFIELDS, payload.c_str());
   curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, writeCallback);
   curl_easy_setopt(curl, CURLOPT_WRITEDATA, &response);
+  curl_easy_setopt(curl, CURLOPT_CAINFO, std::getenv("CURL_CA_BUNDLE"));
 
   CURLcode res = curl_easy_perform(curl);
   curl_easy_cleanup(curl);
@@ -114,6 +116,7 @@ void MQSSRestClient::del(const std::string& path) {
   curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, writeCallback);
   curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void*)&response);
   curl_easy_setopt(curl, CURLOPT_CUSTOMREQUEST, "DELETE");
+  curl_easy_setopt(curl, CURLOPT_CAINFO, std::getenv("CURL_CA_BUNDLE"));
 
   curl_easy_setopt(curl, CURLOPT_HTTPHEADER, pHeaders);