👷 Test generated templates against the exact QDMI revision - #476
Merged
Conversation
Assisted-by: GPT-5.6 via Codex
burgholzer
marked this pull request as ready for review
July 28, 2026 21:12
11 tasks
burgholzer
added a commit
that referenced
this pull request
Jul 29, 2026
🤖 *AI text below* 🤖 ## Description Allow the aggregate `🚦 Check` job to accept skipped test, lint, and template jobs on `pull_request: closed` events. The producer jobs already skip closed pull requests, while the aggregate job previously allowed skips only when change detection marked a job irrelevant. After #476 merged, change detection correctly marked template CI as relevant, the template job skipped because the event was `closed`, and the aggregate job incorrectly treated that skip as a failure in [run 30399676581](https://github.com/Munich-Quantum-Software-Stack/QDMI/actions/runs/30399676581). The allowed-skip expressions now mirror the producer job conditions: tests, lint, and templates may skip on closed events or when their path filters disable them. Documentation remains unchanged because its closed-event path may remove the pull request preview. Other pull request events, pushes, merge-group runs, and manual runs continue to require every relevant job. ## Validation - `uvx prek run -a` - `git diff --check` - Independent read-only review of the closed/non-closed event truth table and documentation cleanup path The definitive hosted regression check is this pull request's own `closed` run after merge. ## Checklist - [x] The pull request only contains commits that are focused and relevant to this change. - [x] The workflow's existing aggregate gate covers the changed behavior. - [x] Documentation changes are not required for this CI-only correction. - [x] A changelog entry is not warranted because there is no user-facing behavior change. - [x] Migration instructions are not needed. - [x] The changes follow the project's style guidelines and introduce no new warnings. - [x] The changes passed the relevant local validation listed above. - [x] The code changes have been independently reviewed. **If PR contains AI-assisted content:** - [x] AI assistance is disclosed at the beginning of this description. - [x] The AI-assisted commit includes the required `Assisted-by` footer. - [x] A human maintainer has personally reviewed and understood all AI-assisted content and accepts responsibility for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Make the reusable template CI build generated projects against the exact QDMI
repository owner and revision being tested.
The job previously generated a standalone project and then fetched mutable
develop. This caused QDMI #475 to fail because its generated project usedfunctionality introduced by that pull request but absent from
develop. Theworkflow now passes the pull request head owner and SHA to the direct CMake
builds and forwards the same
CMAKE_ARGSinto cibuildwheel's Linux containers.Push and merge-queue events fall back to the current repository owner and event
SHA.
The generated template and its normal dependency defaults remain unchanged.
This is a CI-only correction that also makes future template changes test their
exact source revision.
Related to #475.
Validation
uvx prek run -aagainst exact head
c5564bc7a031f6716a4e7bc105ad7aadb4cd79f9CMAKE_ARGSChecklist
this change.
behavior change.
warnings.
If PR contains AI-assisted content:
Assisted-byfooter.content and accepts responsibility for it.