💥 Remove the calibration advisory property - #512
Open
burgholzer wants to merge 1 commit into
Open
Conversation
burgholzer
added
documentation
Contributor
|
burgholzer
force-pushed
the
codex/remove-needs-calibration
branch
2 times, most recently
from
August 24, 2026 19:30
2583d9b to
d358e6b
Compare
11 tasks
Drop the unused NEEDSCALIBRATION device property and close the resulting enum gap. Keep the distinct device calibration status for active provider-reported state. Assisted-by: GPT-5.6 Sol via Codex
burgholzer
force-pushed
the
codex/remove-needs-calibration
branch
from
August 24, 2026 19:35
d358e6b to
2c636b9
Compare
burgholzer
marked this pull request as ready for review
August 24, 2026 19:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
This PR removes
QDMI_DEVICE_PROPERTY_NEEDSCALIBRATIONfrom QDMI v1.4. Theadvisory has no provider-independent use or corresponding calibration operation,
and no known provider reports a useful value. Providers can expose proprietary
calibration readiness through a custom property or a separate vendor interface.
The regular device-property values are renumbered to close the gap. This is
safe for the unreleased v1.4 ABI, which already requires clients and providers
to use matching minor-version headers.
QDMI_DEVICE_STATUS_CALIBRATIONremainsavailable because it reports an active device state rather than an advisory.
This PR is stacked directly on #511.
Local validation passes:
uvx prek run -aChecklist
If PR contains AI-assisted content:
Assisted-by: [Model Name] via [Tool Name]footer.