Conversation
…pted earlier—because self.W10.weights inside an MPSSynapse generates the tensor via an einsum, returning an Array, get() throws an error.
ago109
left a comment
There was a problem hiding this comment.
This looks great (and interesting!); thank you for contributing the MPSSynapse!
One small comment / possible minor update - is there a paper reference we could possibly attach to the main doc-string of MPSSynapse?
For example, in the MSTDPETSynapse, we refer to the source where the mathematical model that the synapse represents comes from where in the main doc-string we have:
"""
| References:
| Florian, Răzvan V. "Reinforcement learning through modulation of spike-timing-dependent synaptic plasticity."
| Neural computation 19.6 (2007): 1468-1502.
"""
That way, we pay credit to you/your team or the researchers that this synapse embodies.
If there is no reference, then possibly a link to the blog-post/tutorial/talk or source where perhaps this was proposed works as well =]
|
Hey Alex, PS |
|
@antonvice Thank you for taking the time to contribute! We really appreciate it! You can increase the tolerance of numpy assert equal a little bit to loosen the condition (as last resort). For example, playing around with rtol and atol. |
|
Hello @antonvice could you please consider @rxng8's suggestion for loosening the tolerance a tiny bit for the unit-test? |
|
The test now works for me! |
rxng8
left a comment
There was a problem hiding this comment.
Overall, the code aligns with the library. The logic and the test cases are reasonable
This PR introduces the MPSSynapse component, allowing for Matrix Product State (MPS) compressed synaptic transformations. This enables high-dimensional layers to scale within memory constraints of biological and robotic inference systems. Includes a utility for SVD-based matrix decomposition into MPS cores.