Repository navigation
ci: keep CodeQL results out of GitHub code scanning - #5
Merged
Merged
Conversation
SonarQube Cloud already imports the CodeQL SARIF as part of the merged report. Uploading it to GitHub as well made each finding also appear as a github-advanced-security alert and PR comment. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
github/codeql-action/analyzestep also uploaded the same results to GitHub code scanning (its default isupload: always), so each finding showed up again as a github-advanced-security alert and PR comment.Proposed Changes
.github/workflows/security-scan.yml: setupload: neveron theCodeQL Scan(codeql-action/analyze) step, with a short comment explaining why.upload: neverstill writes the SARIF to the analyze step's default output directory (../results). ThePost-Process Outputstep reads it from there and passes the processed files to-Dsonar.sarifReportPaths, andUpload Artifactsuploads it, so both keep working unchanged. There is noupload-sarifstep in this repo.Issues
Testing
SonarQubejob log should show the CodeQL step skipping the code-scanning upload, the SARIF in../results, and SonarQube importing it viasonar.sarifReportPaths.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/575ce82ca3794eeda360cf55ebeec352
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/575ce82ca3794eeda360cf55ebeec352?variant=devin
Requested by: @jl-0