Fix issue if no positions in PhaseLine determineLabelPositions method.#19
Open
gbonnary wants to merge 1 commit intoNASAWorldWind:masterfrom
Open
Fix issue if no positions in PhaseLine determineLabelPositions method.#19gbonnary wants to merge 1 commit intoNASAWorldWind:masterfrom
gbonnary wants to merge 1 commit intoNASAWorldWind:masterfrom
Conversation
zglueck
reviewed
Oct 31, 2016
| protected void determineLabelPositions(DrawContext dc) | ||
| { | ||
| Iterator<? extends Position> iterator = this.path.getPositions().iterator(); | ||
| Iterable<? extends Position> positions = this.path.getPositions(); |
Contributor
There was a problem hiding this comment.
Will you remove the extra tab indentation here?
Contributor
|
@gbonnary thanks for pointing this out, we were wondering if you spotted this behavior with any other graphics? |
Author
|
Yes, I've found other issues with this behavior. |
|
Hi @gbonnary. Do you have fixes for some of the other classes? I have added this as a new pull-request to the community-edition of WorldWind (located at: https://github.com/WorldWindEarth/WorldWindJava). The pull-request can be viewed at: WorldWindEarth#12. Would you help us out by opening pull-requests for some of the other issues that you encountered? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MilStd2525GraphicFactory class can create graphics without positions:
pointer null exceptions happen when rendering PhaseLine.