Support property references in XML files#22
Open
rougeSE wants to merge 1 commit intoNASAWorldWind:masterfrom
Open
Support property references in XML files#22rougeSE wants to merge 1 commit intoNASAWorldWind:masterfrom
rougeSE wants to merge 1 commit intoNASAWorldWind:masterfrom
Conversation
When deploying Worldwind within an isolated environments with isloated
WMS servers, there is no way to centralize the definition of the server
name, instead, each of the layer XML files have to be updated.
This change allows any of the WW XML file to contain a property
reference, ${property.name}, and have these properties resolved when the
text is retrieved. Properties can be defined in three different ways;
1)worldwind.xml <Property>, 2) Java system property (-Dproperty.name),
or 3) using the legacy WW properties file.
Contributor
|
@rougeSE thanks for the contribution. The team is heavily focused on some other tasks right now so it may take a bit of time to review your pull request. We do appreciate your willingness to share code! |
rougeSE
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying Worldwind within isolated environments with isloated
WMS servers, there is no way to centralize the definition of the server
name, instead, each of the layer XML files have to be updated.
This change allows any of the WW XML file to contain a property
reference, ${property.name}, and have these properties resolved when the
text is retrieved. Properties can be defined in three different ways;
1)worldwind.xml , 2) Java system property (-Dproperty.name),
or 3) using the legacy WW properties file.
Testing:
UnitTest for WWUtilTest was updated to Perform testing of property reference resolution from Configuration and system properties. Test included nested references and logger generation for missing properties.