Add NCSortInOrder and add NCFilterOutLongPolys to NCGBX#32
Open
jared-hughes wants to merge 2 commits intoNCAlgebra:masterfrom
Open
Add NCSortInOrder and add NCFilterOutLongPolys to NCGBX#32jared-hughes wants to merge 2 commits intoNCAlgebra:masterfrom
jared-hughes wants to merge 2 commits intoNCAlgebra:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes
NCMakeGBwould produce a huge Gröbner basis, soNCProcessprinted out too many polynomials to look at easily. We (Bill+I) found it helpful to cache the output ofNCMakeGB, filter that down (usingNCFilterOutLongPolysintroduced in this PR), then output that without re-computing the Gröbner basis (usingNCSortInOrder).The output of
NCSortInOrderis the same asNCProcess, exceptNCSortInOrderdoes not call theNCMakeGBfirst.Implementation note -- the options are specified separately, so a
SetOptions[NCSortInOrder, {printReport -> False}]would not affect the behavior ofNCProcess, and vice versa.Note I ran
make usageto convert the documentation changes to the .usage file. Not sure if there's anything else in the makefile that should be ran.