Fix front door domain for non apex records - #320
Merged
Merged
Conversation
#319 fixed the log for apex domains, but broke non-apex domains. It incorrectly generated the _dnsauth record with the DNS zone suffix, like _dnsauth.pr-2177.review.run-breast-screening.nhs.uk Fix the domain so it is simply like: _dnsauth.pr-2177.review
saliceti
force-pushed
the
DTOSS-13486-update-domain-fix-apex-logic-2
branch
from
September 24, 2026 14:48
d323b08 to
23c4024
Compare
|
saliceti
marked this pull request as ready for review
September 24, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#319 updated the logic to fix apex domain certificate generation. Unfortunately it broke for non apex domains.
Such as review apps on Manage: https://github.com/NHSDigital/dtos-manage-breast-screening/actions/runs/36002412772/job/107642342691
Update the logic to generate the right dnsauth record.
Testing
See working review app:
https://github.com/NHSDigital/dtos-manage-breast-screening/actions/runs/36011038152/job/107671862808