WIP Arbitration phase 3

TODO.md

@@ -0,0 +1,3 @@
+# TODO
+
+- style-guide/modal.html references `layout-fragment.html`, which doesn't exist — real layout is `_templates/layout-modal-form.html`

app/assets/sass/components/_reading.scss

@@ -117,7 +117,6 @@
 
 .app-placeholder-action-cell {
   padding-right: 15px;
-  text-align: right;
   white-space: nowrap;
 }
 

app/data/session-data-defaults.js

@@ -104,6 +104,7 @@ const defaultSettings = {
     }
   },
   reading: {
+    indexLayout: 'complex', // 'simple' | 'complex'
     blindReading: config.reading.blindReading,
     confirmNormal: 'false',
     confirmNormalWithDetails: 'false',
@@ -115,10 +116,16 @@ const defaultSettings = {
     annotationsMode: 'with-images-simple', // 'without-images' | 'with-images-simple' | 'with-images' | 'with-images-progressive'
     secondReaderComparison: 'off', // 'early' | 'late' | 'off'
     compareWhen: 'non_normal', // 'non_normal' | 'discordant_only'
-    arbitrationPolicy: 'discordant_only', // 'discordant_only' | 'all_recalls' | 'all_non_normal'
     finalisationDelay: '60', // minutes before reads auto-finalise; '0' immediate | 'never' manual only
     lazySessions: 'true',
-    defaultSessionSize: '25'
+    defaultSessionSize: '25',
+    arbitration: {
+      policy: 'discordant_only', // 'discordant_only' | 'all_recalls' | 'all_non_normal'
+      flow: 'compare_first', // 'compare_first' | 'opinion_first' - what an arbitration case opens on
+      confirmDecision: 'true', // show the review page before saving an arbitration decision
+      hideReadsUntilArbitrated: 'true', // overview hides the original opinions until the case is arbitrated
+      lazySessions: 'true'
+    }
   }
 }
 

app/lib/generators/episode-generator.js

@@ -781,7 +781,13 @@ const checkEpisodes = (episodes, appointmentsById) => {
           )
         }
       })
-      if (new Set(reads.map((read) => read.readerId)).size !== reads.length) {
+      // Nobody reads a case twice. An arbitration read is the group's rather
+      // than one reader's, so it is exempt - its authors may include the
+      // original readers.
+      const readerIds = reads
+        .filter((read) => read.readType !== 'arbitration')
+        .map((read) => read.readerId)
+      if (new Set(readerIds).size !== readerIds.length) {
         problems.push(
           `reading case ${readingCase.id} has the same reader twice`
         )

app/lib/generators/reading-generator.js

@@ -780,29 +780,28 @@ const generateReadingData = (appointments, users, episodes, seedProfile = {}) =>
   }
 
   // A FEW VERY RECENT SECOND READS: timestamped inside the finalisation delay,
-  // so the backlog carries live awaiting_finalisation cases - alternating
-  // concordant (finalising towards a conclusion) and forced discordant
-  // (finalising, then arbitration). Drawn from clinics[7], the first of the
-  // partial-first-read pair above - its first reads are recent, so the
-  // oldest-first session ordering the e2e journeys lean on is untouched.
+  // so the backlog carries live awaiting_finalisation cases - mostly forced
+  // discordant (for arbitration), with every 4th concordant. Drawn from
+  // clinics[7] and clinics[8]'s read appointments.
   if (clinics.length >= 9) {
-    const clinic = clinics[7]
-    const candidates = clinic.appointments
+    const candidates = [clinics[7], clinics[8]]
+      .flatMap((clinic) => clinic.appointments)
       .filter((appointment) => readAppointmentIds.has(appointment.id))
-      .slice(0, 8)
+      .slice(0, 20)
 
-    let minutesAgo = 50
+    let minutesAgo = 100
     let count = 0
 
     candidates.forEach((appointment, index) => {
       const readingCase = casesByAppointmentId.get(appointment.id)
       const firstRead = readingCase?.reads?.[0]
       if (!firstRead) return
 
+      // Most cases forced discordant (arbitration), every 5th concordant
       const opinion =
-        index % 2 === 0
-          ? pickSecondOpinion(firstRead, 0) // force disagreement
-          : firstRead.opinion
+        index % 5 === 4
+          ? firstRead.opinion
+          : pickSecondOpinion(firstRead, 0) // force disagreement
 
       addRead(
         readingCase,
@@ -812,7 +811,7 @@ const generateReadingData = (appointments, users, episodes, seedProfile = {}) =>
         { forceOpinion: opinion, alignmentProbability }
       )
 
-      minutesAgo -= 5
+      minutesAgo -= 3
       count++
     })
 
@@ -821,6 +820,48 @@ const generateReadingData = (appointments, users, episodes, seedProfile = {}) =>
     )
   }
 
+  // MORE DISCORDANT SECOND READS: drawn from clinics[5] and clinics[6] (first
+  // read by secondReader), with thirdReader as the disagreeing second reader.
+  // Neither reader is the current user, so all are arbitrable by Jane Hitchin.
+  if (clinics.length >= 7) {
+    let minutesAgo = 95
+    let count = 0
+
+    const candidates = [clinics[5], clinics[6]]
+      .flatMap((clinic) => clinic.appointments)
+      .filter((appointment) => readAppointmentIds.has(appointment.id))
+      .filter((appointment) => {
+        const rc = casesByAppointmentId.get(appointment.id)
+        return rc && rc.reads?.length === 1
+      })
+      .slice(0, 20)
+
+    candidates.forEach((appointment, index) => {
+      const readingCase = casesByAppointmentId.get(appointment.id)
+      const firstRead = readingCase.reads[0]
+
+      const opinion =
+        index % 5 === 4
+          ? firstRead.opinion
+          : pickSecondOpinion(firstRead, 0)
+
+      addRead(
+        readingCase,
+        appointment,
+        thirdReader,
+        dayjs().subtract(minutesAgo, 'minute').toISOString(),
+        { forceOpinion: opinion, alignmentProbability }
+      )
+
+      minutesAgo -= 3
+      count++
+    })
+
+    console.log(
+      `Added ${count} discordant second reads from clinics 5-6 for arbitration`
+    )
+  }
+
   // A COUPLE OF DEFERRED CASES: deferred by a reader with a reason, so the
   // deferred list and the case view's deferral detail have real data behind
   // them. Drawn from clinics[8]'s unread remainder, matching how deferral