Skip to content

APPT-659 Booking reference update for scaling and security#1168

Draft
jsed-nhs wants to merge 4 commits intomainfrom
APPT-659_booking_ref_update_3
Draft

APPT-659 Booking reference update for scaling and security#1168
jsed-nhs wants to merge 4 commits intomainfrom
APPT-659_booking_ref_update_3

Conversation

@jsed-nhs
Copy link
Contributor

@jsed-nhs jsed-nhs commented Nov 18, 2025

DRAFT

@jsed-nhs jsed-nhs marked this pull request as draft November 18, 2025 10:31
@jsed-nhs jsed-nhs force-pushed the APPT-659_booking_ref_update_3 branch from 0b06441 to 9c221f8 Compare November 19, 2025 12:36
@jsed-nhs
Squashed commit of the following:
8642308 
commit 33e7069
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Fri Oct 31 15:18:05 2025 +0000

    Add BookingRef V2 flag enabled/disabled tests to all the Booking Integration tests

commit ff85c28
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Fri Oct 31 11:00:16 2025 +0000

    Update casing of Reference Hmac Key and add to vars, and tf settings

commit f5748ad
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 21:26:06 2025 +0000

    Add ReferenceNumberHmacKey to dockercompose. TODO - add to env tf vars

commit a9630c4
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 19:26:16 2025 +0000

    Add new flag to all env json files

commit 7b7bab4
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 19:20:33 2025 +0000

    booking_reference removal from cosmosDB seeder and add creation if not exists on first use in an env

commit 8822fd4
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 15:00:29 2025 +0000

    Add V2 Provider reference

commit 207aa69
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 14:43:44 2025 +0000

    Limit regex matchTimeout to 100ms

commit 13ef7ad
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 14:09:27 2025 +0000

    Rebase fix

commit e67686a
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 14:05:27 2025 +0000

    Cache tests

commit 30b946e
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 13:41:55 2025 +0000

    Add obsolete flags to V1 code so that it is marked for deletion in time

commit 56ec2f4
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 12:46:16 2025 +0000

    Luhn invalid check logs warning

commit 1b3b968
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 12:25:33 2025 +0000

    V1 IsValidBookingReference supported

commit 7a11ade
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Thu Oct 30 12:15:38 2025 +0000

    Add tests in for V1/V2 reference use in BWS tests. Include a transition test where initial uses V1, and reschedule uses V2.

commit b44ac1c
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Wed Oct 29 13:54:17 2025 +0000

    Booking reference generation behind feature flag

commit 424e9d4
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Wed Oct 29 13:43:51 2025 +0000

    Readd current RefProvider and split into V1 and V2 namespaces

commit ea865bf
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Tue Oct 28 14:23:39 2025 +0000

    Fix tests

commit 0fc1478
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Tue Oct 28 12:11:35 2025 +0000

    Reapplied WIP

commit 3945324
Author: jsed-nhs <193929923+jsed-nhs@users.noreply.github.com>
Date:   Tue Oct 28 11:04:24 2025 +0000

    Booking Reference Docs

# Conflicts:
#	src/api/Nhs.Appointments.Core/Bookings/ReferenceNumberProvider.cs
#	src/api/Nhs.Appointments.Core/Sites/ISiteStore.cs
#	src/api/Nhs.Appointments.Persistance/Reference/ReferenceGroupCosmosDocumentStore.cs
#	src/api/Nhs.Appointments.Persistance/SiteStore.cs
#	tests/Nhs.Appointments.Api.Integration/Scenarios/Booking/BookingBaseFeatureSteps.cs
#	tests/Nhs.Appointments.Api.Integration/Scenarios/Booking/QueryBookingByNhsNumber.cs
#	tests/Nhs.Appointments.Core.UnitTests/ReferenceNumber/V1/ReferenceNumberProviderTests.cs
@jsed-nhs
Fix rebase issues
7e6b100
@jsed-nhs
Replaced sequenceMultiplier cache storage with DB storage and updated…
ce9cc90 
… tests.
@jsed-nhs
Fix unit test
011a648
@jsed-nhs jsed-nhs force-pushed the APPT-659_booking_ref_update_3 branch from 86aefc8 to 011a648 Compare November 20, 2025 12:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2025

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jsed-nhs jsed-nhs changed the title APPT-659 Booking reference update for scaling and security (folder rebase) APPT-659 Booking reference update for scaling and security Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jsed-nhs