Skip to content

APPT-1932 Include unsupported bookings in scheduled list#1475

Open
jsed-nhs wants to merge 8 commits intomainfrom
APPT-1932/manual_cancellations_2
Open

APPT-1932 Include unsupported bookings in scheduled list#1475
jsed-nhs wants to merge 8 commits intomainfrom
APPT-1932/manual_cancellations_2

Conversation

@jsed-nhs
Copy link
Contributor

@jsed-nhs jsed-nhs commented Mar 3, 2026

Description

Remove manual cancellations tab along with href links that point to it, to now point to the scheduled tab.

Scheduled tab should now comprise of all Booked appointments, regardless of 'Supported' or 'Orphaned' status.

Do not migrate 'manual-cancellations' message to the scheduled tab - that used to appear i.e. "X booked appointments are affected due to an edit to your availability. These bookings are still scheduled until you click "Cancel".`" OR "There are no booked appointments affected by availability changes."

Update the appointments metrics so that the 'Total Appointments' now equals MaximumCapacity + OrphanedBookings count.

Reword 'manual cancellation' day card message for both week and day cards to now read "X bookings were kept when availability was changed or cancelled." OR "1 booking was kept when availability was changed or cancelled." for singular grammar.

Update global.css to have consistent viewport-height margin between appointment summary card items to better align with UCD designs. This will scale with the users view for dynamic margins. Apply a similar fix to nhs-pagination, nhs-wrapper and links.

Set appointment card headers to all be H3, down from H2's.

Jest tests added/updated.
Playwright greedy model test updated for metrics and wording.

Unnecessary padding/margins fix (extra) - Pipe-delimited-links and Breadcrumbs was unnecessarily rendering in the DOM and taking up real estate, even when no content visible. Make components return undefined in these cases.

Breadcrumb fix (extra) - CSS was off for home link on anonymous page, brought within Content wrapper.

breadcrumb-fix new-view new-view2 orphaned-scheduled

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

jsed-nhs added 6 commits March 3, 2026 18:55
…rapper and back/breadcrumb link to use consistent margins that are viewport height-ed. Fix both the breadcrumbs and pipe-delimited-links components to not render if no items provided (prevents unnecessary DOM padding). Fix breadcrumb on NHSAnon page so its within content.
@jsed-nhs jsed-nhs changed the title Appt 1932/manual cancellations 2 APPT-1932 Include unsupported bookings in scheduled list Mar 3, 2026
Dave-O-NHS
Dave-O-NHS previously approved these changes Mar 4, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
5.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants