APPT-1932 Include unsupported bookings in scheduled list#1475
Open
APPT-1932 Include unsupported bookings in scheduled list#1475
Conversation
…rapper and back/breadcrumb link to use consistent margins that are viewport height-ed. Fix both the breadcrumbs and pipe-delimited-links components to not render if no items provided (prevents unnecessary DOM padding). Fix breadcrumb on NHSAnon page so its within content.
Dave-O-NHS
previously approved these changes
Mar 4, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Remove manual cancellations tab along with href links that point to it, to now point to the scheduled tab.
Scheduled tab should now comprise of all Booked appointments, regardless of 'Supported' or 'Orphaned' status.
Do not migrate 'manual-cancellations' message to the scheduled tab - that used to appear i.e. "X booked appointments are affected due to an edit to your availability. These bookings are still scheduled until you click "Cancel".`" OR "There are no booked appointments affected by availability changes."
Update the appointments metrics so that the 'Total Appointments' now equals MaximumCapacity + OrphanedBookings count.
Reword 'manual cancellation' day card message for both week and day cards to now read "X bookings were kept when availability was changed or cancelled." OR "1 booking was kept when availability was changed or cancelled." for singular grammar.
Update global.css to have consistent viewport-height margin between appointment summary card items to better align with UCD designs. This will scale with the users view for dynamic margins. Apply a similar fix to nhs-pagination, nhs-wrapper and links.
Set appointment card headers to all be H3, down from H2's.
Jest tests added/updated.
Playwright greedy model test updated for metrics and wording.
Unnecessary padding/margins fix (extra) - Pipe-delimited-links and Breadcrumbs was unnecessarily rendering in the DOM and taking up real estate, even when no content visible. Make components return undefined in these cases.
Breadcrumb fix (extra) - CSS was off for home link on anonymous page, brought within Content wrapper.
Checklist: