CCM-21858: APIM Auth module - #237
Conversation
gareth-allan
left a comment
gareth-allan
left a comment
There was a problem hiding this comment.
I've not been over the source or TF files yet, but some comments on the other bits.
There was a problem hiding this comment.
Not something to do in this PR, but I wonder if we could create an npm package containing this default ESLint config and publish it for other repos to consume? It would make it easier to keep everything aligned and push out any future updates, and you could still override specific settings on a per-repo basis if you wanted.
| minimum_protocol_version = "TLSv1.2_2021" | ||
| ssl_support_method = "sni-only" | ||
| } | ||
|
|
There was a problem hiding this comment.
Nudge and Digital Letters have a logging_config entry in their equivalents of this file. Has it been deliberately omitted here?
There was a problem hiding this comment.
Yes I don't think we actually need logging for cloudfront but happy to follow Platform's lead.
2 participants
Description
This PR is to create an APIM Authentication shared module contains all the components required for APIM authentication:
The output of the module is the SSM parameter containing the APIM token that will be automatically refreshed every 9 minutes.
This PR also contains changes in order to:
The 2 lambdas and utils library have been copied directly from the Digital Letters BC.
Check https://github.com/NHSDigital/nhs-notify-deep-ping/pull/40 for test evidence.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.