CCM-22077: Adding replace SG on delete to Lambda - #239
Open
aidenvaines-cgi wants to merge 1 commit into
Open
Conversation
chris-elliott-nhsd
approved these changes
Aug 10, 2026
timireland
approved these changes
Aug 10, 2026
karlmcgi
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adding replace_security_groups_on_destroy to Lambda module
Context
Fixes (i hope) lambda taking AAAAAAGES to destroy lambda functions if in a VPC
Without replacement:
Lambda is deleted.
AWS-managed VPC ENIs for that Lambda can linger for up to 45 minutes -> ENIs still reference the Lambda SG -> SG delete blocked
With replace_security_groups_on_destroy:
Terraform updates the Lambda first, swapping its VPC security groups to a different set.
New or surviving ENIs attach to the replacement group, not the original one.
The original security group is now decoupled from active Lambda networking sooner.
Terraform can delete the old group much earlier, reducing long in-use waits.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.