Notes on single.py#100
Open
LourensVeen wants to merge 1 commit intoNLeSC:masterfrom
LourensVeen:single-notes
Open
Notes on single.py#100LourensVeen wants to merge 1 commit intoNLeSC:masterfrom LourensVeen:single-notes
LourensVeen wants to merge 1 commit intoNLeSC:masterfrom
LourensVeen:single-notes
Conversation
|
|
||
| from cytoolz import identity, pipe | ||
| import nltk | ||
| import spotlight |
Member
Author
There was a problem hiding this comment.
Why are nltk and spotlight imported globally, and e.g. frog locally? Especially spotlight is only used in one function.
Collaborator
There was a problem hiding this comment.
Local imports are lazy. They're used when importing causes work to be performed (e.g. starting a Stanford NER wrapper Java process thingy).
Member
Author
There was a problem hiding this comment.
Ah, okay. I thought it was a scoping issue, but you're not dragging anything into another namespace here.
larsmans
added a commit
that referenced
this pull request
Apr 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some notes on single.py that I can't easily fix myself. See the inline comments.