Skip to content

Improve NuGet preview package naming for non-master builds #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
304NotModified merged 2 commits into from
Mar 9, 2026
+35 −14
Merged

Improve NuGet preview package naming for non-master builds #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e29332a
Initial plan
Copilot Mar 9, 2026
8af0ceb
Update nuget.yml: use pwsh, fix PR branch name, add PR number and run…
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 35 additions & 14 deletions .github/workflows/nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,45 @@

- name: Determine version suffix
id: version
shell: bash
shell: pwsh
run: |
if [[ "$GITHUB_REF" == "refs/heads/master" ]]; then
echo "suffix=" >> $GITHUB_OUTPUT
else
CLEAN=$(echo "$GITHUB_REF_NAME" | sed 's/[^a-zA-Z0-9]/-/g' | sed 's/-\+/-/g' | sed 's/^-//;s/-$//')
echo "suffix=$CLEAN" >> $GITHUB_OUTPUT
fi
$ref = "${{ github.ref }}"
if ($ref -eq "refs/heads/master") {
echo "suffix=" >> $env:GITHUB_OUTPUT
} else {
# For a PR: use head_ref (actual branch name), otherwise the ref name
$branchName = "${{ github.head_ref }}"

Check failure on line 40 in .github/workflows/nuget.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Change this workflow to not use user-controlled data directly in a run block. 


See more on https://sonarcloud.io/project/issues?id=nlog.mailkit&issues=AZzQwku5LSFP-gpYmi1n&open=AZzQwku5LSFP-gpYmi1n&pullRequest=239
if ([string]::IsNullOrEmpty($branchName)) {
$branchName = "${{ github.ref_name }}"
}

# Sanitize: non-alphanumeric -> '-', multiple '-' -> one, trim '-'
$clean = $branchName -replace '[^a-zA-Z0-9]', '-' `
-replace '-+', '-' `
-replace '^-|-$', ''
# Truncate to max 40 characters and remove trailing '-'
$short = if ($clean.Length -gt 0) { $clean.Substring(0, [Math]::Min(40, $clean.Length)).TrimEnd('-') } else { "" }

# PR number prefix
$prNumber = "${{ github.event.pull_request.number }}"
$prPrefix = if ($prNumber) { "pr${prNumber}-" } else { "" }

# Build number
$build = "${{ github.run_number }}"

$suffix = "${prPrefix}${short}.${build}"
echo "suffix=$suffix" >> $env:GITHUB_OUTPUT
}

- name: Pack
shell: bash
shell: pwsh
run: |
VERSION_SUFFIX="${{ steps.version.outputs.suffix }}"
if [ -n "$VERSION_SUFFIX" ]; then
dotnet pack src/NLog.MailKit.sln --no-build --configuration Release --output artifacts --version-suffix "$VERSION_SUFFIX"
else
$versionSuffix = "${{ steps.version.outputs.suffix }}"
if ($versionSuffix) {
dotnet pack src/NLog.MailKit.sln --no-build --configuration Release --output artifacts --version-suffix "$versionSuffix"
} else {
dotnet pack src/NLog.MailKit.sln --no-build --configuration Release --output artifacts
fi
}

- name: Upload nuget package
uses: actions/upload-artifact@v4
Expand All @@ -64,5 +85,5 @@

- name: Push to NuGet.org
if: github.ref == 'refs/heads/master'
shell: bash
shell: pwsh
run: dotnet nuget push artifacts/*.nupkg --api-key ${{ steps.login.outputs.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json --skip-duplicate
Loading