Skip to content

refactor(split_functional_groups)#20

Open
kellijohnson-NOAA wants to merge 1 commit intomainfrom
group-fxn
Open

refactor(split_functional_groups)#20
kellijohnson-NOAA wants to merge 1 commit intomainfrom
group-fxn

Conversation

@kellijohnson-NOAA
Copy link
Copy Markdown
Contributor

What is the feature?

  • Split functional groups from left to right rather than right to left. This allows for all types of patterns to be matched rather than relying on a certain formatting for the grouping structure within a species.

How have you implemented the solution?

  • PascalCase and camelCase words are first transformed to sentence case and leading brackets are transformed to a space and trailing brackets are removed.
  • split_functional_groups() looks for common groups by searching character by character through all combinations of x.
  • Words are then split between common groups and trailing information. The trailing information is the grouping and common group is the species.
  • A data frame is returned (same as before).

Does the PR impact any other area of the project, maybe another repo?

  • @Bai-Li-NOAA can you test this on your functional groups for the simulation project to see if I need to do any augmenting.

Split functional groups from left to right rather than right to left.
This allows for all types of patterns to be matched rather than relying
on a certain formatting for the grouping structure within a species.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant