Repository navigation
Complete ITOps UI release readiness - #188
NPFernando wants to merge 13 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90721139d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Fork avoids paying the full interpreter/import startup cost for every | ||
| # small comparison on Unix. Keep spawn as the portable fallback for | ||
| # platforms where fork is unavailable. | ||
| start_method = "fork" if "fork" in mp.get_all_start_methods() else "spawn" |
There was a problem hiding this comment.
Keep spawn for Streamlit worker processes
On Unix deployments this explicitly forks from Streamlit's multithreaded ScriptRunner, so the child can inherit locked synchronization primitives and deadlock or crash, turning valid Text Diff submissions into spurious three-second timeout failures. The repository already documents this exact constraint in utils/regex_tools.py:66-70 and deliberately uses spawn; retain that method here rather than selecting fork for startup speed.
Useful? React with 👍 / 👎.
| ( | ||
| "Review logs or incidents", | ||
| "Use the app’s guided checks to triage a report, confirm the health status, and prepare evidence.", | ||
| ("log_troubleshooting_assistant", "health_diagnostics", "roadmap_feedback"), |
There was a problem hiding this comment.
Use valid targets for the incident quick start
The incident card references two identifiers absent from TOOLS: the registered log-tool slug is log_troubleshooting, not log_troubleshooting_assistant, and Roadmap is not registered under roadmap_feedback. Because _resolve_slugs silently skips unknown values after numbering has already occurred, users see only 2. Health Diagnostics and lose steps 1 and 3 from this newly advertised workflow.
Useful? React with 👍 / 👎.
|
|
||
| - Local: ahead by one commit. | ||
| - Remote: ahead by two commits. | ||
| - Working tree: local Home/UI changes are not committed yet. |
There was a problem hiding this comment.
Remove stale pre-commit status from the release handoff
Once this commit exists, the assertion that these Home/UI changes are still uncommitted is already false, and the following instructions tell release operators to perform a commit and reconcile branch counts that describe only the author's transient checkout. This makes the committed operations handoff misleading in every clone; record durable verification state or the reviewed commit instead of ephemeral local branch status.
AGENTS.md reference: AGENTS.md:L44-L44
Useful? React with 👍 / 👎.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up audit and hardening pushed in commit
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up implementation is pushed in commits
Local release evidence passes, and PR CI plus Socket Security checks pass for the current head. Maintainer review remains required before merge. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Validation
make release-evidence.venv/bin/python -m pytest -qProduction note
Authenticated production smoke verification remains blocked until a logged-in browser session is available. Unauthenticated requests redirect to the deployment login flow and are not treated as production sign-off evidence.