Skip to content

New Developed Codes for SAXS-GiSAXS_XPCS#12

Open
Yugang Zhang (yugangzhang) wants to merge 2 commits intoNSLS2:mainfrom
yugangzhang:GiSAXS_Dev
Open

New Developed Codes for SAXS-GiSAXS_XPCS#12
Yugang Zhang (yugangzhang) wants to merge 2 commits intoNSLS2:mainfrom
yugangzhang:GiSAXS_Dev

Conversation

@yugangzhang
Copy link
Copy Markdown
Contributor

Codes developed at May 2016

Codes developed at May 2016
Comment thread chxtools/Circular_Average.py Outdated
# return the three arrays
return bins, val, count

def bin_edges_to_centers(input_edges):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yugang Zhang (@yugangzhang) isn't this the same function in skbeam/utils bin_edges_to_centers function?

Comment thread chxtools/Mask_Maker.py
@@ -0,0 +1,131 @@
from chx_libs import *
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these relative imports (from .chx_libs import *) and, better yet, import only the parts you need (from chx_libs import some_func, another_func) so it is clear to the reader where all the functions below came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants