Skip to content

Remove references to PI scanner#410

Open
Shekar V (vshekar) wants to merge 2 commits into
NSLS2:masterfrom
vshekar:Remove-PI-scanner
Open

Remove references to PI scanner#410
Shekar V (vshekar) wants to merge 2 commits into
NSLS2:masterfrom
vshekar:Remove-PI-scanner

Conversation

@vshekar

Copy link
Copy Markdown
Collaborator

PI scanner is no longer used at FMX. It also uses old style PV changing to run the collection. If the scanner comes back its worth rewriting using bluesky

PI scanner is no longer used at FMX. It also uses old style PV changing
to run the collection. If the scanner comes back its worth rewriting
using bluesky

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes all references to the PI scanner hardware from the LSDC (Large Scale Data Collection) system at FMX beamline. The PI scanner is no longer in use and relied on old-style PV (Process Variable) changing methods for data collection.

Changes:

  • Removed PI scanner configuration checks and conditional logic throughout the codebase
  • Deleted two utility modules (Gen_Commands.py and Gen_Traj_Square.py) that were exclusively used for PI scanner trajectory generation
  • Simplified raster scanning logic to remove PI-specific code paths including fine motor positioning

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
gui/control_main.py Removed scannerType configuration, fine motor (fineX/Y/Z) PV callbacks and position tracking, simplified raster cell indexing logic
daq_macros.py Removed Gen_Commands and Gen_Traj_Square imports, deleted PI-specific raster functions (snakeRasterFine, snakeRasterNoTile, vectorZebraScanFine, gridRaster, etc.), simplified snakeRaster and vectorZebraScan functions, removed setScannerType configuration function
Gen_Traj_Square.py Deleted entire file containing PI scanner trajectory generation code
Gen_Commands.py Deleted entire file containing PI scanner command generation code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gui/control_main.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants