Closed
Conversation
* already included in lock file, so no update necessary
* read TILED_API_KEY in from env.secrets
* corresponding changes in prefect3_worker role
* include possibility of calling with API key value to better enable local testing of workflows
* publish-ghcr and the deploy file had the local branch name to use for testing. change those to main for prod
* enable running on hosts without access to our filesystems, such as Github action-based CI
* remove dry_run from reading functions * make get_run() function and use it where Tiled clients are required * remove redundant utils module
* no need to import it from end_of_run_workflow()
Contributor
Author
|
closing as the key change is now incorporated in #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed yesterday that the Tiled API key which is passed around the functions is visible on Prefect Cloud when the workflow is run in production.
This fix will ensure the Tiled API key is only read from the environment file right where it is used so that it is not passed around.
The Tiled API key used in the
end_of_run_workflow()function is currently only used when testing, either CI or local interactive testing. In these cases, Prefect Cloud will not store the parameters used to call the functions, so the API key will never get exposed.Note that this PR also includes the dotenv change.