refactor to use dry_run, move Tiled jobs into tasks#8
Draft
Jun Aishima (JunAishima) wants to merge 3 commits intoNSLS2:mainfrom
Draft
refactor to use dry_run, move Tiled jobs into tasks#8Jun Aishima (JunAishima) wants to merge 3 commits intoNSLS2:mainfrom
Jun Aishima (JunAishima) wants to merge 3 commits intoNSLS2:mainfrom
Conversation
* return data from read function
Contributor
Abby Giles (AbbyGi)
left a comment
Abby Giles (AbbyGi)
left a comment
There was a problem hiding this comment.
This is a good idea, just had one minor fix and another comment.
| def log_completion(dry_run=False): | ||
| logger = get_run_logger() | ||
| logger.info("Complete") | ||
| logger.info(f"Complete! dry_run:{dry_run}") |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.info(f"Complete! dry_run:{dry_run}") | |
| logger.info(f"Complete! dry_run: {dry_run}") |
| logger.info(f"{elapsed_time = }") | ||
|
|
||
|
|
||
| @flow |
Contributor
There was a problem hiding this comment.
It feels a bit weird to call a flow (read_all_streams) from within a flow (data_validation) when everything is related to doing data validation. Maybe we can consider moving whatever is in read_all_streams into data_validation so we only have one flow?
Jun Aishima (JunAishima)
added a commit
that referenced
this pull request
Feb 25, 2026
* this PR now incorporates the branch `refactor-tasks` and includes a minor print formatting change and removing the extra layer of flow
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main objective - enable testing the workflow by adding a dry run option. This will enable the general logic to be tested. In the case of the data validation flow, make the dry run avoid reading the run metadata, and reading the data from the streams.
Secondary objective - reading the data from Tiled is subject to network and server issues. Thus, I have moved these kinds of operations into tasks, with retry capability set.