Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two main improvements to the tasking application: (1) it adds a new map layer for NSW Declared Dams, and (2) it makes the alerts panel's collapsible behavior configurable by the user, including UI and state management changes. These enhancements improve both the data available to users and the flexibility of the alerts interface.
New Map Layer: NSW Declared Dams
registerNSWDeclaredDamsLayerfunction inmapLayers/dams.jsto display NSW Declared Dams on the map using Esri Leaflet, with custom styling and popups showing dam details.main.js) so it appears as an option in the UI. [1] [2]Configurable Alerts Panel Collapsibility
alertsCollapsibleRulesto the configuration viewmodel, persisted in config, and exposed in the UI as a toggle switch under "Alerts Panel" in settings. [1] [2] [3] [4] [5]alerts.jsto respect the newalertsCollapsibleRulessetting, allowing users to control whether alert panels are collapsible or always expanded. This includes changes to state management, event handling, and ARIA attributes for accessibility. [1] [2] [3] [4] [5] [6] [7]