Repository navigation
Add GPU BitBIRCH clustering - #372
Merged
Merged
Conversation
bitBirchGpu clusters packed fingerprints of up to 4096 bits with one BitBIRCH tree. Each insertion batch routes against a stable snapshot of the tree; one ordered owner per leaf then merges or appends that leaf's rows, summaries are refreshed bottom-up from per-batch deltas, and overflowing leaves split at a barrier in leaf order, cascading into parents. Rows past the first 16384 that would each merge into the same entry are first tried as one group. Cluster IDs follow each cluster's earliest row. Each step has one implementation for any branching factor: nodes keep contiguous entry lists, split pair searches tile node entries, and leaf owners compare a batch of rows against the whole leaf in one pass. Similarities are correctly rounded FP32 quotients, which order exactly up to 4096 bits; iSIM merge tests use exact integer terms. Tests cover the iSIM primitives and small cases checked against the Python reference model, including cascading splits and leaves split across two pair-search tiles.
Contributor
 [Medium impact] The PR appears safe to merge, with no new actionable issue found.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
scal444
changed the title
…ariant test - Replace hand-written block sum/min/argmax and the iSIM reduction with cub::BlockReduce. - Drop the exact-integer iSIM branch: every FP64 term is an integer, so FP64 sums are already exact below 2^53, and the reduction order is fixed. - insertRows: thread 0 reads the tree status and broadcasts it, so a failure in another block cannot split one block across a barrier. - Copy centroids one word per thread during finalization (coalesced). - Remove the int stashed in the reduction scratch and a shadowed local. - Link cub_helpers/host_vector instead of the unused device library; link device to test_bitbirch, which uses ScopedStream. - Add a seeded 20k-row test past the ordered warm-up that checks cluster invariants (threshold, majority centroids, dense first-row order, determinism) without stored fixtures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
PR 1/2 for #321 |
evasnow1992
approved these changes
Oct 22, 2026
evasnow1992
left a comment
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python bindings + more extensive integration tests to come in the followup