Repository navigation
Speed up GETAWAY ITH/ISH clustering - #379
Merged
scal444 merged 1 commit intoOct 26, 2026
Merged
Conversation
ITH and ISH group the rounded heavy-atom leverages with RDKit's clusterArray2, a greedy scan comparing the printed values with IsClose2. Lane 0 used to run the scan alone, and each leverage's printed text was built in character arrays that lived in local memory. - The warp now runs the scan a cluster at a time: all lanes test up to 32 followers of the cluster's front at once and a ballot finds the first one that is not close. - Cluster keys (leading zeros, length and leading integer of the printed fraction) are derived from the rounded significand's digits directly, with 32-bit division when the significand fits, so no text is built. - exactPowerOfTen() multiplies binary-digit factors instead of indexing a table, which also lived in local memory. The clustering follows RDKit's exactly as before, so results are unchanged.
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found.
|
evasnow1992
approved these changes
Oct 23, 2026
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the optimization! Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITH and ISH group the rounded heavy-atom leverages with RDKit's clusterArray2, a greedy scan comparing the printed values with IsClose2. Lane 0 used to run the scan alone, and each leverage's printed text was built in character arrays that lived in local memory.
The clustering follows RDKit's exactly as before, so results are unchanged.