Repository navigation
Match RDKit 2026.09 standard ETKDG setup - #384
Merged
Merged
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable defects were established.
|
RDKit 2026.09 builds the ETKDG torsion terms after the topology bounds, which now record forced amide/ester 1-4 configurations that become torsion terms, and keeps one experimental torsion per central bond. nvMolKit used the legacy setTopolBounds overload before initETKDG, so those torsions were dropped and duplicate central-bond terms were kept. - Set topology bounds through a version-aware helper that uses the EmbedParameters overload and records path14Configs on 2026.09. - Run initETKDG after bounds setup on 2026.09. - Keep the first experimental torsion per central bond on 2026.09. - Reject parameters nvMolKit does not implement instead of ignoring them: all-in-one refinement, embedForceField=MMFF, onlyInitialEmbedding and internal-coordinate initial embedding. embedMolecules validates them before looking at the molecules. - Treat initialEmbeddingMode=RANDOM_COORDINATE_EMBEDDING as useRandomCoords. RDKit 2026.09 deprecates the flag for the mode but still applies its random-coordinate basin threshold and 4D embedding only for the flag. As in RDKit, useRandomCoords also selects that mode, overriding internal-coordinate embedding. - Tests: forced amide torsion and one term per central bond on 2026.09, experimental torsion energies against RDKit's construct3DForceField, 2026.09 hexane bounds, 2026.09 chiral dist-matrix failure count, each rejected setting in C++ and Python, embedding with only the random-coordinate mode set, and drop the positional EmbedParameters constructor removed in 2026.03.4.
scal444
force-pushed
the
feat/etkdg-2609-setup
branch
from
October 28, 2026 20:08
6ddd7a2 to
4f568a0
Compare
Collaborator
Author
|
This is 1 of 4 for getting to parity with RDKit 2026.9 ETKDG |
evasnow1992
approved these changes
Oct 29, 2026
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKit 2026.09 builds the ETKDG torsion terms after the topology bounds, which now record forced amide/ester 1-4 configurations that become torsion terms, and keeps one experimental torsion per central bond. nvMolKit used the legacy setTopolBounds overload before initETKDG, so those torsions were dropped and duplicate central-bond terms were kept.