[docs] docs: Add model variant pages#3930
Open
yaoyu-33 wants to merge 1 commit into
Open
Conversation
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Light Code ReviewLGTM — docs-only PR adding model-variant leaf pages. All referenced implementation paths (bridge modules, recipes, example directories) verified to exist on this branch. No bugs, typos, or missing references found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit supported model variants after #3908 and add missing model-variant leaf pages where the repo clearly has bridge/example/recipe support but docs only had family/index coverage.
Added leaf pages for:
Also updated family index toctrees,
docs/models/README.md,docs/index.md, and the root README supported-model table for StepFun.Audit notes
Sources checked:
README.mdsupported models tabledocs/models/*/index.mdand existingdocs/models/*/*.mdexamples/models/*andexamples/megatron_mimosrc/megatron/bridge/models/*src/megatron/bridge/recipes/*Intentionally kept grouped rather than split further:
llama3.mdbecause they share the existing Llama 3 page and recipe family.qwen.mdbecause the existing page already covers the shared dense Qwen bridge and recipes.nemotronh.mdbecause the page explicitly covers both shared hybrid SSM-attention families.MiniMaxM2ForCausalLMarchitecture.Validation
git diff --checkpassed.docs/models/*/index.mdtoctree entries resolve.cd docs && uv run --no-sync sphinx-build --fail-on-warning --builder html . _build/htmlwas blocked because the unsynced venv did not havesphinx-buildinstalled.cd docs && uv run --group docs sphinx-build --fail-on-warning --builder html . _build/htmlwas blocked by the local resolver/platform issue:nvidia-resiliency-ext==0.6.0has no wheel for this host'smanylinux_2_31_x86_64; available wheels aremanylinux_2_39_*.cd docs && uv run --no-project --with sphinx --with myst-parser --with sphinx-autodoc2 --with nvidia-sphinx-theme --with sphinx-copybutton --with sphinxcontrib-mermaid sphinx-build --fail-on-warning --builder html . _build/html.uv run pre-commit run --all-fileswas blocked by the samenvidia-resiliency-extplatform resolver issue.uv run --no-project --with pre-commit pre-commit run --all-files.Unit tests were not run, per task instructions.